Enable libpkix to handle AIA chasing when compiled statically

Enable libpkix to handle AIA chasing when compiled statically

In order to prevent a circular dependency, upstream NSS has
libpkix dlopen [lib]smime3 to access the CERT_DecodeCertPackage
function, which handles decoding PEM/DER certificates from the
web.

However, when built as Chromium does, [lib]smime3 doesn't exist,
and thus all AIA chasing fails. Instead, for builds where all of
NSS is linked into a single library (static or dynamic), directly
link to the function (with the assistance of an extern).

BUG=176541

[Ryan Sleevi, 2013-02-28 22:49:52]

Wan-Teh: I still need to break out the patch file and add some AIA unit tests
for TestServer, but the code is good to go.

[wtc, 2013-03-01 00:29:47]

Patch set 1 LGTM. Thanks.

I wonder how hard it is to write a simple subset of
PKCS #7 decoding for CERT_DecodeCertPackage() and move it
to libnss3.so.  This kind of circular dependency is bad.

https://codereview.chromium.org/12383037/diff/1/mozilla/security/nss/lib/libp...
File mozilla/security/nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c
(right):

https://codereview.chromium.org/12383037/diff/1/mozilla/security/nss/lib/libp...
mozilla/security/nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c:205:
extern SECStatus CERT_DecodeCertPackage(char*, int, CERTImportCertificateFunc,
void*);
This seems to be longer than 80 chars. I would include the
function parameter names in the declaration.

https://codereview.chromium.org/12383037/diff/1/mozilla/security/nss/lib/libp...
mozilla/security/nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c:229:
pkix_decodeFunc.func = &CERT_DecodeCertPackage;
The & is not necessary in C89 and later.

[commit-bot: I haz the power, 2013-05-15 19:24:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12383037/5001

[commit-bot: I haz the power, 2013-05-15 19:24:41]

Change committed as 200333