Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: content/renderer/pepper/pepper_platform_audio_input_impl.h

Issue 12383016: Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase after r194401 (removal of flush) Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_platform_audio_input_impl.h
diff --git a/content/renderer/pepper/pepper_platform_audio_input_impl.h b/content/renderer/pepper/pepper_platform_audio_input_impl.h
index 7d71347d5a53d1a1d82501ae067730756a1cf6c2..b398f11e2890858324e82ac4f2ef3040548ae9cc 100644
--- a/content/renderer/pepper/pepper_platform_audio_input_impl.h
+++ b/content/renderer/pepper/pepper_platform_audio_input_impl.h
@@ -9,9 +9,8 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
-#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
-#include "content/renderer/media/audio_input_message_filter.h"
+#include "media/audio/audio_input_ipc.h"
#include "media/audio/audio_parameters.h"
#include "webkit/plugins/ppapi/plugin_delegate.h"
@@ -21,7 +20,6 @@ class AudioParameters;
namespace content {
-class AudioInputMessageFilter;
class PepperPluginDelegateImpl;
// PepperPlatformAudioInputImpl is operated on two threads: the main thread (the
@@ -94,14 +92,7 @@ class PepperPlatformAudioInputImpl
// Used to send/receive IPC. THIS MUST ONLY BE ACCESSED ON THE
// I/O thread except to send messages and get the message loop.
- scoped_refptr<AudioInputMessageFilter> ipc_;
-
- // Our ID on the MessageFilter. THIS MUST ONLY BE ACCESSED ON THE I/O THREAD
- // or else you could race with the initialize function which sets it.
- int32 stream_id_;
-
- // The render view into which the audio is sent.
- int render_view_id_;
+ scoped_ptr<media::AudioInputIPC> ipc_;
yzshen1 2013/04/17 05:27:23 - nit: please include scoped_ptr.h. - does the 'ex
miu 2013/04/17 20:01:38 Done.
base::MessageLoopProxy* main_message_loop_proxy_;
@@ -112,10 +103,6 @@ class PepperPlatformAudioInputImpl
// THE MAIN THREAD.
std::string label_;
- // Whether ShutDownOnIOThread() has been called. THIS MUST ONLY BE ACCESSED ON
- // THE I/O THREAD.
- bool shutdown_called_;
-
// Initialized on the main thread and accessed on the I/O thread afterwards.
media::AudioParameters params_;

Powered by Google App Engine
This is Rietveld 408576698