Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1238283002: Collect SQL statistics on passwords. Print more information on error. (Closed)

Created:
5 years, 5 months ago by vasilii
Modified:
5 years, 5 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Collect SQL statistics on passwords. Print more information on error. BUG=419070 Committed: https://crrev.com/675ab9b362ddfac24965928efd9b59c9f35d5f1c Cr-Commit-Position: refs/heads/master@{#339449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M components/password_manager/core/browser/login_database.cc View 1 chunk +17 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vasilii
Hi guys, please review the CL.
5 years, 5 months ago (2015-07-20 11:53:36 UTC) #2
Mike West
login_database.cc LGTM.
5 years, 5 months ago (2015-07-20 12:08:03 UTC) #3
Alexei Svitkine (slow)
lgtm
5 years, 5 months ago (2015-07-20 14:55:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238283002/1
5 years, 5 months ago (2015-07-20 15:05:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 15:32:44 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 15:33:39 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/675ab9b362ddfac24965928efd9b59c9f35d5f1c
Cr-Commit-Position: refs/heads/master@{#339449}

Powered by Google App Engine
This is Rietveld 408576698