Collect SQL statistics on passwords. Print more information on error.

components/password_manager/core/browser/login_database.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
@@ skipping 194 matching lines @@
 
 LoginDatabase::~LoginDatabase() {
 }
 
 bool LoginDatabase::Init() {
   // Set pragmas for a small, private database (based on WebDatabase).
   db_.set_page_size(2048);
   db_.set_cache_size(32);
   db_.set_exclusive_locking();
   db_.set_restrict_to_user();
+  db_.set_histogram_tag("Passwords");
 
   if (!db_.Open(db_path_)) {
-    LOG(WARNING) << "Unable to open the password store database.";
+    LOG(ERROR) << "Unable to open the password store database.";
     return false;
   }
 
   sql::Transaction transaction(&db_);
-  transaction.Begin();
+  if (!transaction.Begin()) {
+    LOG(ERROR) << "Unable to start a transaction.";
+    db_.Close();
+    return false;
+  }
 
   // Check the database version.
   if (!meta_table_.Init(&db_, kCurrentVersionNumber,
                         kCompatibleVersionNumber)) {
+    LOG(ERROR) << "Unable to create the meta table.";
     db_.Close();
     return false;
   }
   if (meta_table_.GetCompatibleVersionNumber() > kCurrentVersionNumber) {
-    LOG(WARNING) << "Password store database is too new.";
+    LOG(ERROR) << "Password store database is too new, kCurrentVersionNumber="
+               << kCurrentVersionNumber << ", GetCompatibleVersionNumber="
+               << meta_table_.GetCompatibleVersionNumber();
     db_.Close();
     return false;
   }
 
   // Initialize the tables.
   if (!InitLoginsTable()) {
-    LOG(WARNING) << "Unable to initialize the logins table.";
+    LOG(ERROR) << "Unable to initialize the logins table.";
     db_.Close();
     return false;
   }
 
   if (!stats_table_.Init(&db_)) {
-    LOG(WARNING) << "Unable to initialize the stats table.";
+    LOG(ERROR) << "Unable to initialize the stats table.";
     db_.Close();
     return false;
   }
 
   // If the file on disk is an older database version, bring it up to date.
   if (!MigrateOldVersionsAsNeeded()) {
-    LOG(WARNING) << "Unable to migrate database";
+    LOG(ERROR) << "Unable to migrate database from "
+               << meta_table_.GetVersionNumber() << " to "
+               << kCurrentVersionNumber;
     db_.Close();
     return false;
   }
 
   if (!transaction.Commit()) {
+    LOG(ERROR) << "Unable to commit a transaction.";
     db_.Close();
     return false;
   }
 
   return true;
 }
 
 bool LoginDatabase::MigrateOldVersionsAsNeeded() {
   switch (meta_table_.GetVersionNumber()) {
     case 1:
@@ skipping 707 matching lines @@
     UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering",
                               psl_domain_match_metric, PSL_DOMAIN_MATCH_COUNT);
   }
 
   if (!statement->Succeeded())
     return false;
   return true;
 }
 
 }  // namespace password_manager