Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: utils/pub/log.dart

Issue 12382031: Make pub warning-clean. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/io.dart ('k') | utils/pub/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/log.dart
diff --git a/utils/pub/log.dart b/utils/pub/log.dart
index 606aa41d4f1e405dc7e68ee9cf07cd8f25cb24ed..5f1c578ad930e2f73b665daadf4e1c9dd3db1321 100644
--- a/utils/pub/log.dart
+++ b/utils/pub/log.dart
@@ -117,22 +117,22 @@ void process(String executable, List<String> arguments) {
void processResult(String executable, PubProcessResult result) {
// Log it all as one message so that it shows up as a single unit in the logs.
var buffer = new StringBuffer();
- buffer.add("Finished $executable. Exit code ${result.exitCode}.");
+ buffer.write("Finished $executable. Exit code ${result.exitCode}.");
dumpOutput(String name, List<String> output) {
if (output.length == 0) {
- buffer.add("Nothing output on $name.");
+ buffer.write("Nothing output on $name.");
} else {
- buffer.add("$name:");
+ buffer.write("$name:");
var numLines = 0;
for (var line in output) {
if (++numLines > 1000) {
- buffer.add('[${output.length - 1000}] more lines of output '
- 'truncated...]');
+ buffer.write('[${output.length - 1000}] more lines of output '
+ 'truncated...]');
break;
}
- buffer.add(line);
+ buffer.write(line);
}
}
}
« no previous file with comments | « utils/pub/io.dart ('k') | utils/pub/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698