Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: utils/pub/io.dart

Issue 12382031: Make pub warning-clean. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | utils/pub/log.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index a8ec15891557bcbc5d9f96e9bbbe13b0035bdb4f..381ed53bbe0970356a732f4c308a9218815a796e 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -188,7 +188,7 @@ Future<List<String>> listDir(String dir,
log.fine("Listed directory $dir:\n${contents.join('\n')}");
completer.complete(contents);
},
- onError: (error) => completer.completeError(error, stackTrace));
+ onError: (error) => completer.completeError(error));
return completer.future.then((contents) {
return Future.wait(children).then((childContents) {
@@ -605,7 +605,7 @@ Future timeout(Future input, int milliseconds, String description) {
}).catchError((e) {
if (completed) return;
timer.cancel();
- completer.completeError(e.error, e.stackTrace);
+ completer.completeError(e);
});
return completer.future;
}
@@ -716,8 +716,8 @@ Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
/// Returns a [ByteStream] that will emit the contents of the archive.
ByteStream createTarGz(List contents, {baseDir}) {
var buffer = new StringBuffer();
- buffer.add('Creating .tag.gz stream containing:\n');
- contents.forEach((file) => buffer.add('$file\n'));
+ buffer.write('Creating .tag.gz stream containing:\n');
+ contents.forEach((file) => buffer.write('$file\n'));
log.fine(buffer.toString());
var controller = new StreamController<List<int>>();
« no previous file with comments | « no previous file | utils/pub/log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698