Issue 12382019: Merge 143917

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12382019: Merge 143917 (Closed)

Created:
7 years, 9 months ago by Peter Beverloo

Modified:
7 years, 9 months ago

Reviewers:
Peter Beverloo

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

Merge 143917 > [Chromium] Disable registerProtocolHandler on Android > https://bugs.webkit.org/show_bug.cgi?id=110481 > > Patch by Anton Vayvod <avayvod@chromium.org>; on 2013-02-25 > Reviewed by Julien Chaffraix. > > Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't > actually wired up internally. Disable the feature to avoid breaking feature detection until > we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465 > See the discussion of the future implementation at http://crbug.com/156386 > > * features.gypi: Disable the flag for Android, enable it only for non-Android platforms. > > * src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144321

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	Source/WebKit/chromium/features.gypi	View		3 chunks	+2 lines, -2 lines	0 comments	Download
	M	Source/WebKit/chromium/src/ChromeClientImpl.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r144321.