Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12381054: Add a number of connection type fields to ExtraData instead of using the fields on WebURLResponse. … (Closed)

Created:
7 years, 9 months ago by Ryan Hamilton
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a number of connection type fields to ExtraData instead of using the fields on WebURLResponse. They will be removed from WebURLResponse in: https://bugs.webkit.org/show_bug.cgi?id=111237 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186257

Patch Set 1 #

Total comments: 2

Patch Set 2 : Chrome style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -14 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 chunks +12 lines, -6 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M webkit/glue/weburlresponse_extradata_impl.h View 1 1 chunk +43 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Hamilton
I'm not particularly familiar with the multi-step webkit/chromium dance, so please let me know if ...
7 years, 9 months ago (2013-03-02 01:02:30 UTC) #1
darin (slow to review)
Awesome, thanks for working on this!! https://codereview.chromium.org/12381054/diff/1/webkit/glue/weburlresponse_extradata_impl.h File webkit/glue/weburlresponse_extradata_impl.h (right): https://codereview.chromium.org/12381054/diff/1/webkit/glue/weburlresponse_extradata_impl.h#newcode31 webkit/glue/weburlresponse_extradata_impl.h:31: bool wasFetchedViaProxy() const ...
7 years, 9 months ago (2013-03-04 05:35:48 UTC) #2
Ryan Hamilton
https://codereview.chromium.org/12381054/diff/1/webkit/glue/weburlresponse_extradata_impl.h File webkit/glue/weburlresponse_extradata_impl.h (right): https://codereview.chromium.org/12381054/diff/1/webkit/glue/weburlresponse_extradata_impl.h#newcode31 webkit/glue/weburlresponse_extradata_impl.h:31: bool wasFetchedViaProxy() const { On 2013/03/04 05:35:48, darin wrote: ...
7 years, 9 months ago (2013-03-04 17:27:09 UTC) #3
darin (slow to review)
LGTM
7 years, 9 months ago (2013-03-05 08:14:01 UTC) #4
Ryan Hamilton
On 2013/03/05 08:14:01, darin wrote: > LGTM Thanks!
7 years, 9 months ago (2013-03-05 17:33:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/12381054/3002
7 years, 9 months ago (2013-03-05 17:34:36 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 21:03:37 UTC) #7
Message was sent while issue was closed.
Change committed as 186257

Powered by Google App Engine
This is Rietveld 408576698