Second codegen test passing on ARM (simulated).

runtime/vm/instructions_arm.cc

Index: runtime/vm/instructions_arm.cc
===================================================================
--- runtime/vm/instructions_arm.cc	(revision 19272)
+++ runtime/vm/instructions_arm.cc	(working copy)
@@ -67,7 +67,8 @@
 void CallPattern::SetTargetAddress(uword target_address) const {
   ASSERT(Utils::IsAligned(target_address, 4));
   // The address is stored in the object array as a RawSmi.
-  const Smi& smi = Smi::Handle(Smi::New(target_address >> kSmiTagShift));
+  const intptr_t signed_target_address = static_cast<intptr_t>(target_address);

[srdjan, 2013/03/01 17:46:28]

I'd like to discuss this code in person.

[regis, 2013/03/04 17:52:18]

As explained in person, the signed shift right is canceled out by the signed
shift left in Smi::New. I've changed the code not to use Smi::New, to make it
clearer.

+  const Smi& smi = Smi::Handle(Smi::New(signed_target_address >> kSmiTagShift));
   object_pool_.SetAt(pool_index_, smi);
 }