Second codegen test passing on ARM (simulated).

runtime/vm/instructions_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/instructions.h"
 #include "vm/object.h"
 
@@ skipping 49 matching lines @@
 uword CallPattern::TargetAddress() const {
   const Object& target_address = Object::Handle(object_pool_.At(pool_index_));
   ASSERT(target_address.IsSmi());
   return Smi::Cast(target_address).Value() << kSmiTagShift;
 }
 
 
 void CallPattern::SetTargetAddress(uword target_address) const {
   ASSERT(Utils::IsAligned(target_address, 4));
   // The address is stored in the object array as a RawSmi.
-  const Smi& smi = Smi::Handle(Smi::New(target_address >> kSmiTagShift));
+  const intptr_t signed_target_address = static_cast<intptr_t>(target_address);

[srdjan, 2013/03/01 17:46:28]

I'd like to discuss this code in person.

[regis, 2013/03/04 17:52:18]

As explained in person, the signed shift right is canceled out by the signed
shift left in Smi::New. I've changed the code not to use Smi::New, to make it
clearer.

+  const Smi& smi = Smi::Handle(Smi::New(signed_target_address >> kSmiTagShift));
   object_pool_.SetAt(pool_index_, smi);
 }
 
 
 bool JumpPattern::IsValid() const {
   UNIMPLEMENTED();
   return false;
 }
 
 
 uword JumpPattern::TargetAddress() const {
   UNIMPLEMENTED();
   return 0;
 }
 
 
 void JumpPattern::SetTargetAddress(uword target) const {
   UNIMPLEMENTED();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM