Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1237983004: Revert of Make instrumentation test dependency on a support APK explicit (Closed)

Created:
5 years, 5 months ago by Yusuf
Modified:
5 years, 5 months ago
Reviewers:
cjhopman, jbudorick, dgn
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make instrumentation test dependency on a support APK explicit (patchset #8 id:130001 of https://codereview.chromium.org/1208483004/) Reason for revert: Cast tests failing on ToT after this. Original issue's description: > Make instrumentation test dependency on a support APK explicit > > Add an argument (support_apk_name) to the GYP and GN > instrumentation_test_apk targets to provide a support APK. The > argument is optional, but when present, the build will fail if the > APK is not installable > > BUG=501797 > > Committed: https://crrev.com/0ac9fec88bf9a042410192b304ae1bc252df8aa7 > Cr-Commit-Position: refs/heads/master@{#339046} TBR=jbudorick@chromium.org,cjhopman@chromium.org,dgn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501797 Committed: https://crrev.com/72c598c090ae4f8df7c55bae7acc8dfea46ba0c6 Cr-Commit-Position: refs/heads/master@{#339170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -32 lines) Patch
M build/android/gyp/create_test_runner_script.py View 2 chunks +0 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/test_package.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/test_runner.gypi View 2 chunks +0 lines, -9 lines 0 comments Download
M build/android/test_runner.py View 2 chunks +2 lines, -5 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuf
Created Revert of Make instrumentation test dependency on a support APK explicit
5 years, 5 months ago (2015-07-16 23:32:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237983004/1
5 years, 5 months ago (2015-07-16 23:35:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 23:40:40 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 23:41:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72c598c090ae4f8df7c55bae7acc8dfea46ba0c6
Cr-Commit-Position: refs/heads/master@{#339170}

Powered by Google App Engine
This is Rietveld 408576698