Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 1237983004: Revert of Make instrumentation test dependency on a support APK explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/test_runner.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 9 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir) 10 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
(...skipping 1536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1547 test_runner_args += [ 1547 test_runner_args += [
1548 "--suite", 1548 "--suite",
1549 invoker.test_suite, 1549 invoker.test_suite,
1550 ] 1550 ]
1551 } else if (_test_type == "instrumentation") { 1551 } else if (_test_type == "instrumentation") {
1552 assert(defined(invoker.test_apk)) 1552 assert(defined(invoker.test_apk))
1553 test_runner_args += [ 1553 test_runner_args += [
1554 "--test-apk", 1554 "--test-apk",
1555 invoker.test_apk, 1555 invoker.test_apk,
1556 ] 1556 ]
1557 if (defined(invoker.support_apk_path)) {
1558 test_runner_args += [
1559 "--support-apk",
1560 rebase_path(invoker.support_apk_path, root_build_dir),
1561 ]
1562 }
1563 } else { 1557 } else {
1564 assert(false, "Invalid test type: $_test_type.") 1558 assert(false, "Invalid test type: $_test_type.")
1565 } 1559 }
1566 1560
1567 if (defined(invoker.isolate_file)) { 1561 if (defined(invoker.isolate_file)) {
1568 test_runner_args += [ 1562 test_runner_args += [
1569 "--isolate-file-path", 1563 "--isolate-file-path",
1570 rebase_path(invoker.isolate_file, root_build_dir), 1564 rebase_path(invoker.isolate_file, root_build_dir),
1571 ] 1565 ]
1572 } 1566 }
1573 1567
1574 generated_script = "$root_build_dir/bin/run_${_test_name}" 1568 generated_script = "$root_build_dir/bin/run_${_test_name}"
1575 outputs = [ 1569 outputs = [
1576 depfile, 1570 depfile,
1577 generated_script, 1571 generated_script,
1578 ] 1572 ]
1579 args = [ 1573 args = [
1580 "--depfile", 1574 "--depfile",
1581 rebase_path(depfile, root_build_dir), 1575 rebase_path(depfile, root_build_dir),
1582 "--script-output-path", 1576 "--script-output-path",
1583 rebase_path(generated_script, root_build_dir), 1577 rebase_path(generated_script, root_build_dir),
1584 ] 1578 ]
1585 args += test_runner_args 1579 args += test_runner_args
1586 } 1580 }
1587 } 1581 }
OLDNEW
« no previous file with comments | « build/android/test_runner.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698