Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1237953002: Simplify PrepareForDataProperty in the IsElement case (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify PrepareForDataProperty in the IsElement case BUG=v8:4137 LOG=n Committed: https://crrev.com/e5c2a69637cae21bf42da1589edcc48c90eeef10 Cr-Commit-Position: refs/heads/master@{#29678}

Patch Set 1 #

Patch Set 2 : Only used to modify an existing value, so don't make holey #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -62 lines) Patch
M src/lookup.cc View 1 1 chunk +7 lines, -21 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-15 10:09:31 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-15 10:45:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237953002/20001
5 years, 5 months ago (2015-07-15 11:44:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-15 12:13:08 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 12:13:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5c2a69637cae21bf42da1589edcc48c90eeef10
Cr-Commit-Position: refs/heads/master@{#29678}

Powered by Google App Engine
This is Rietveld 408576698