src/objects-inl.h - Issue 1237953002: Simplify PrepareForDataProperty in the IsElement case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1237953002: Simplify PrepareForDataProperty in the IsElement case (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Only used to modify an existing value, so don't make holey Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 857270f674a288cec36cb450b0f6e204e0c1a175..188722e62814e655b73ec21039b769a64bcf157f 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -695,8 +695,7 @@ bool Object::IsJSReceiver() const {

bool Object::IsJSObject() const {

STATIC_ASSERT(LAST_JS_OBJECT_TYPE == LAST_TYPE);

- return IsHeapObject() &&

- HeapObject::cast(this)->map()->instance_type() >= FIRST_JS_OBJECT_TYPE;

+ return IsHeapObject() && HeapObject::cast(this)->map()->IsJSObjectMap();

}

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »