Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12379040: Revert 185474 -- speculative. browser_tests stopped starting up on all (Closed)

Created:
7 years, 9 months ago by Nico
Modified:
7 years, 9 months ago
Reviewers:
girard
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Revert 185474 -- speculative. browser_tests stopped starting up on all xp bots. I'm guessing the GetProcAddressed() function might misbehave on XP. > Fix touch scaling for high dpi windows. > > Touch events in windows are always expressed in screen coordinates, even if > the target app is not dpi-aware. This patch determines the dpi scale used > by the OS, and re-scales touch events accordingly. > > In some cases the touch events are sent to the wrong window. This is detected > and corrected. > > BUG=175542 > > > Review URL: https://chromiumcodereview.appspot.com/12317157 TBR=girard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -60 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/base/win/dpi.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/win/dpi.cc View 3 chunks +0 lines, -33 lines 0 comments Download
M ui/base/win/hwnd_subclass.cc View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
7 years, 9 months ago (2013-03-01 09:29:05 UTC) #1
Nico
Committed patchset #1 manually as r185502.
7 years, 9 months ago (2013-03-01 09:30:00 UTC) #2
Nico
The revert helped. Before: http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28dbg%29%283%29&number=32276 After: http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28dbg%29%283%29&number=32277 (also on all the other xp dbg bots ...
7 years, 9 months ago (2013-03-01 10:00:40 UTC) #3
girard
On 2013/03/01 10:00:40, Nico wrote: > The revert helped. > > Before: > http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%2520Tests%2520%2528dbg%2529%25283%2529&number=32276 > ...
7 years, 9 months ago (2013-03-01 15:07:27 UTC) #4
girard
On 2013/03/01 15:07:27, girard wrote: > On 2013/03/01 10:00:40, Nico wrote: > > The revert ...
7 years, 9 months ago (2013-03-04 18:51:57 UTC) #5
Nico
7 years, 9 months ago (2013-03-04 18:53:25 UTC) #6
On Mon, Mar 4, 2013 at 7:51 PM,  <girard@chromium.org> wrote:
> On 2013/03/01 15:07:27, girard wrote:
>>
>> On 2013/03/01 10:00:40, Nico wrote:
>> > The revert helped.
>> >
>> > Before:
>> >
>
>
>
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%252520Tests%2...
>>
>> > After:
>> >
>
>
>
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%252520Tests%2...
>
>> >
>> > (also on all the other xp dbg bots running browser_tests and
>> > content_browsertests)
>
>
>> Thanks for applying the revert.
>
>
>> I can't imagine how this code could affect browser_tests, since all of the
>> modified code paths are behind WM_TOUCH events, and we aren't directly
>> linking
>> to any unavailable entry points. Inconceivable! (In other words, I'll test
>> on
>
> XP
>>
>> to find out what I've screwed up.)
>
>
> I've tested under XP, and the unit tests run correctly/consistently. I'm
> going
> to assume the tests were flaky and try a re-submit.
>
> https://codereview.chromium.org/12379040/

They consistently failed on all 6 xp dbg bots on the main waterfall
the second this landed. I'd be surprised if that didn't happen again.
Feel free to reland, but please do watch the bots closely.

Powered by Google App Engine
This is Rietveld 408576698