Issue 12379034: Fixes for how extension ids are calculated, especially for component extensions.

Issue 12379034: Fixes for how extension ids are calculated, especially for component extensions. (Closed)

Created:
7 years, 9 months ago by achuithb

Modified:
7 years, 9 months ago

Reviewers:
dtu, zel

CC:
chromium-reviews, chrome-speed-team+watch_google.com, Aaron Boodman, telemetry+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fixes for how extension ids are calculated, especially for component extensions. * Depends on https://codereview.chromium.org/12385037/ * Add crx_id.HasPublicKey * Introduce exception ComponentExtensionMissingPublicKey. Component extensions must have a public key specified. Add a unit test to ensure this exception is raised. * If an extension has a public key, use that to calculate extension_id, if not, use the local file path. BUG=177372 TEST=run_tests --browser=cros-chrome --remote=172.22.71.22 testComponentExtension NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185617

Patch Set 1 #

Patch Set 2 : rename #

Total comments: 4

Patch Set 3 : dtu feedback #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
M	tools/telemetry/telemetry/core/chrome/crx_id.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/core/extension_to_load.py	View	1 2	2 chunks	+13 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/extension_unittest.py	View	1 2	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

achuithb

This fixes component extension unit tests, both on the device and on desktop. Please review ...

7 years, 9 months ago (2013-03-01 02:38:46 UTC) #1

dtu

lgtm with nits https://codereview.chromium.org/12379034/diff/2001/tools/telemetry/telemetry/core/extension_to_load.py File tools/telemetry/telemetry/core/extension_to_load.py (right): https://codereview.chromium.org/12379034/diff/2001/tools/telemetry/telemetry/core/extension_to_load.py#newcode11 tools/telemetry/telemetry/core/extension_to_load.py:11: class ComponentExtensionMissingPublicKey(Exception): MissingPublicKeyException https://codereview.chromium.org/12379034/diff/2001/tools/telemetry/telemetry/core/extension_unittest.py File tools/telemetry/telemetry/core/extension_unittest.py ...

7 years, 9 months ago (2013-03-01 23:17:47 UTC) #2

achuithb

Thanks for the review! https://codereview.chromium.org/12379034/diff/2001/tools/telemetry/telemetry/core/extension_to_load.py File tools/telemetry/telemetry/core/extension_to_load.py (right): https://codereview.chromium.org/12379034/diff/2001/tools/telemetry/telemetry/core/extension_to_load.py#newcode11 tools/telemetry/telemetry/core/extension_to_load.py:11: class ComponentExtensionMissingPublicKey(Exception): On 2013/03/01 23:17:47, ...

7 years, 9 months ago (2013-03-01 23:28:02 UTC) #3

achuithb

7 years, 9 months ago (2013-03-01 23:28:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r185617 (presubmit successful).

Expand Messages | Collapse Messages