Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/telemetry/telemetry/core/extension_unittest.py

Issue 12379034: Fixes for how extension ids are calculated, especially for component extensions. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: dtu feedback Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/extension_to_load.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/extension_unittest.py
===================================================================
--- tools/telemetry/telemetry/core/extension_unittest.py (revision 185386)
+++ tools/telemetry/telemetry/core/extension_unittest.py (working copy)
@@ -115,10 +115,10 @@
self.assertEquals('abcdef', extension.EvaluateJavaScript('_testVar'))
class ComponentExtensionTest(unittest.TestCase):
- def testComponentExtension(self):
+ def testComponentExtensionBasic(self):
extension_path = os.path.join(os.path.dirname(__file__),
'..', '..', 'unittest_data', 'component_extension')
- load_extension = extension_to_load.ExtensionToLoad(extension_path, False)
+ load_extension = extension_to_load.ExtensionToLoad(extension_path, True)
options = options_for_unittests.GetCopy()
options.extensions_to_load = [load_extension]
@@ -131,3 +131,11 @@
extension = b.extensions[load_extension]
extension.ExecuteJavaScript('setTestVar("abcdef")')
self.assertEquals('abcdef', extension.EvaluateJavaScript('_testVar'))
+
+ def testComponentExtensionNoPublicKey(self):
+ # simple_extension does not have a public key.
+ extension_path = os.path.join(os.path.dirname(__file__),
+ '..', '..', 'unittest_data', 'simple_extension')
+ self.assertRaises(extension_to_load.MissingPublicKeyException,
+ lambda: extension_to_load.ExtensionToLoad(extension_path,
+ True))
« no previous file with comments | « tools/telemetry/telemetry/core/extension_to_load.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698