Issue 12378085: Properly handle misses for StoreArrayLengthStub on ia32 and x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12378085: Properly handle misses for StoreArrayLengthStub on ia32 and x64 (Closed)

Created:
7 years, 9 months ago by adamk

Modified:
7 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, Jakob Kummerow, rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly handle misses for StoreArrayLengthStub on ia32 and x64 Both failed to generate a miss if the key wasn't "length". ARM and MIPS were already correct. BUG=v8:2566 Committed: http://code.google.com/p/v8/source/detail?r=13828

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -9 lines)			Patch
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2566.js	View	1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Woops! Thanks for fixing this! LGTM

Expand Messages | Collapse Messages