src/x64/code-stubs-x64.cc - Issue 12378085: Properly handle misses for StoreArrayLengthStub on ia32 and x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 12378085: Properly handle misses for StoreArrayLengthStub on ia32 and x64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index e2ca0718f65f11ff6475c8980c9059714311c640..269cabb97721ab9081a854a3725ea5dc8874b877 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -2481,6 +2481,7 @@ void StoreArrayLengthStub::Generate(MacroAssembler* masm) {

if (kind() == Code::KEYED_STORE_IC) {

__ Cmp(rcx, masm->isolate()->factory()->length_string());

+ __ j(not_equal, &miss);

}

// Check that the receiver isn't a smi.

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | test/mjsunit/regress/regress-2566.js » ('j') | no next file with comments »