Use msvs toolchain from depot_tools.

Use msvs toolchain from depot_tools.

This ports some code from chromium for using the bundled
toolchain.

BUG=chromium:548586
LOG=n

Committed: https://crrev.com/52276b36a015827880a7a0f40eb86412137a9493
Cr-Commit-Position: refs/heads/master@{#31706}

[Michael Achenbach, 2015-10-30 10:41:16]

Description was changed from

==========
Prepare enabling goma for windows.

BUG=
==========

to

==========
Use msvs toolchain from depot_tools.

This ports some code from chromium for using the bundled
toolchain.

BUG=chromium:548586
LOG=n
==========

[Michael Achenbach, 2015-10-30 10:44:19]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, scottmg@chromium.org

[Michael Achenbach, 2015-10-30 10:44:20]

PTAL. Is there some logics in chromium that'll force a full recompile if the
msvs version changes?

https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8
File build/gyp_v8 (right):

https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8#newcode54
build/gyp_v8:54: def GetOutputDirectory():
1:1 c/p from chromium

https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8#newcode106
build/gyp_v8:106: vs2013_runtime_dll_dirs =
vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
1:1 c/p from chromium

https://codereview.chromium.org/1237803003/diff/180001/build/standalone.gypi
File build/standalone.gypi (left):

https://codereview.chromium.org/1237803003/diff/180001/build/standalone.gypi#...
build/standalone.gypi:209: # goma doesn't support PDB yet, so win_z7=1 or
fastbuild=1.
This was an old c/p that was never exercised in v8.

[Michael Achenbach, 2015-10-30 11:54:18]

FYI: This passed our staging bot v8_win64_ninja_rel where goma is enabled and
the MSVS_VERSION variable is unset.

[Michael Achenbach, 2015-10-30 11:54:22]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 11:54:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237803003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237803003/180001

[commit-bot: I haz the power, 2015-10-30 12:01:54]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7242)

[Michael Achenbach, 2015-10-30 12:02:20]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 12:02:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237803003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237803003/200001

[jochen (gone - plz use gerrit), 2015-10-30 12:14:27]

no idea

lgtm anyways

[commit-bot: I haz the power, 2015-10-30 12:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 12:55:00]

Dry run: This issue passed the CQ dry run.

[scottmg, 2015-10-30 16:29:25]

On 2015/10/30 10:44:20, Michael Achenbach wrote:
> PTAL. Is there some logics in chromium that'll force a full recompile if the
> msvs version changes?

We use build/landmines.py for this.

> 
> https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8
> File build/gyp_v8 (right):
> 
> https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8#newcode54
> build/gyp_v8:54: def GetOutputDirectory():
> 1:1 c/p from chromium
> 
> https://codereview.chromium.org/1237803003/diff/180001/build/gyp_v8#newcode106
> build/gyp_v8:106: vs2013_runtime_dll_dirs =
> vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
> 1:1 c/p from chromium
> 
> https://codereview.chromium.org/1237803003/diff/180001/build/standalone.gypi
> File build/standalone.gypi (left):
> 
>
https://codereview.chromium.org/1237803003/diff/180001/build/standalone.gypi#...
> build/standalone.gypi:209: # goma doesn't support PDB yet, so win_z7=1 or
> fastbuild=1.
> This was an old c/p that was never exercised in v8.

[scottmg, 2015-10-30 16:29:41]

lgtm

https://codereview.chromium.org/1237803003/diff/180001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1237803003/diff/180001/build/vs_toolchain.py#...
build/vs_toolchain.py:1: #!/usr/bin/env python
We should really move most of this file to depot_tools so it's not copied all
over the place. :/

[Michael Achenbach, 2015-10-31 18:37:15]

https://codereview.chromium.org/1237803003/diff/180001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/1237803003/diff/180001/build/vs_toolchain.py#...
build/vs_toolchain.py:1: #!/usr/bin/env python
On 2015/10/30 16:29:41, scottmg wrote:
> We should really move most of this file to depot_tools so it's not copied all
> over the place. :/

How about to buildtools for a start?

[Michael Achenbach, 2015-11-02 10:01:36]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-11-02 10:01:36]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1237803003/#ps220001
(title: "Adding a landmine")

[commit-bot: I haz the power, 2015-11-02 10:01:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237803003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237803003/220001

[commit-bot: I haz the power, 2015-11-02 10:40:22]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-11-02 10:40:36]

Patchset 12 (id:??) landed as
https://crrev.com/52276b36a015827880a7a0f40eb86412137a9493
Cr-Commit-Position: refs/heads/master@{#31706}