build/gyp_environment.py - Issue 1237803003: Use msvs toolchain from depot_tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_environment.py

Issue 1237803003: Use msvs toolchain from depot_tools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Adding a landmine Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_environment.py

diff --git a/build/gyp_environment.py b/build/gyp_environment.py

index f1cee6ef8e00f628dc54e319bc39fb6f4fb146f3..7a4e62214826881d5c30d7cacea600dbed1bd156 100644

--- a/build/gyp_environment.py

+++ b/build/gyp_environment.py

@@ -10,6 +10,7 @@ make sure settings are consistent between them, all setup should happen here.

import os

import sys

+import vs_toolchain

SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))

V8_ROOT = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir))

@@ -50,3 +51,4 @@ def set_environment():

# Update the environment based on v8.gyp_env

gyp_env_path = os.path.join(os.path.dirname(V8_ROOT), 'v8.gyp_env')

apply_gyp_environment(gyp_env_path)

+ vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()

« no previous file with comments | « build/get_landmines.py ('k') | build/gyp_v8 » ('j') | no next file with comments »