 Chromium Code Reviews
 Chromium Code Reviews Issue 12377023:
  Use author as determined from scm if we can not get it from rietveld  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
    
  
    Issue 12377023:
  Use author as determined from scm if we can not get it from rietveld  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools| Index: presubmit_canned_checks.py | 
| diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py | 
| index f8513b78b8c9a68959306d97a01956dab0a7838c..6fa4ea4843c52f6aecdaf255d1a6ba1a3989bb4c 100644 | 
| --- a/presubmit_canned_checks.py | 
| +++ b/presubmit_canned_checks.py | 
| @@ -793,19 +793,16 @@ def CheckOwners(input_api, output_api, source_file_filter=None, | 
| owners_db.email_regexp, | 
| approval_needed=input_api.is_committing) | 
| - if author_counts_as_owner: | 
| - if owner_email: | 
| - message = '' | 
| - reviewers_plus_owner = reviewers.union(set([owner_email])) | 
| - else: | 
| - message = ('\nUntil the issue is uploaded, this list will include ' | 
| - 'files for which you are an OWNER.') | 
| - owner_email = '' | 
| - reviewers_plus_owner = set() | 
| + if not owner_email: | 
| 
M-A Ruel
2013/03/03 01:58:57
owner_email = owner_email or input_api.change.auth
 
Dirk Pranke
2013/03/04 21:41:12
Done.
 | 
| + owner_email = input_api.change.author_email | 
| + | 
| + message = '' | 
| 
M-A Ruel
2013/03/03 01:58:57
this line doesn't seem useful anymore.
 
Dirk Pranke
2013/03/04 21:41:12
You're right. Removed the reference, below, as wel
 | 
| + | 
| + if author_counts_as_owner and owner_email: | 
| + reviewers_plus_owner = set([owner_email]).union(reviewers or set()) | 
| missing_files = owners_db.files_not_covered_by(affected_files, | 
| - reviewers_plus_owner) | 
| + reviewers_plus_owner) | 
| else: | 
| - message = '' | 
| missing_files = owners_db.files_not_covered_by(affected_files, reviewers) | 
| if missing_files: |