Use author as determined from scm if we can not get it from rietveld

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 775 matching lines @@
 
   affected_files = set([f.LocalPath() for f in
       input_api.change.AffectedFiles(file_filter=source_file_filter)])
 
   owners_db = input_api.owners_db
   owner_email, reviewers = _RietveldOwnerAndReviewers(
       input_api,
       owners_db.email_regexp,
       approval_needed=input_api.is_committing)
 
-  if author_counts_as_owner:
-    if owner_email:
-      message = ''
-      reviewers_plus_owner = reviewers.union(set([owner_email]))
-    else:
-      message = ('\nUntil the issue is uploaded, this list will include '
-                 'files for which you are an OWNER.')
-      owner_email = ''
-      reviewers_plus_owner = set()
+  if not owner_email:

[M-A Ruel, 2013/03/03 01:58:57]

owner_email = owner_email or input_api.change.author_email

[Dirk Pranke, 2013/03/04 21:41:12]

Done.

+    owner_email = input_api.change.author_email
+
+  message = ''

[M-A Ruel, 2013/03/03 01:58:57]

this line doesn't seem useful anymore.

[Dirk Pranke, 2013/03/04 21:41:12]

You're right. Removed the reference, below, as well.

+
+  if author_counts_as_owner and owner_email:
+    reviewers_plus_owner = set([owner_email]).union(reviewers or set())
     missing_files = owners_db.files_not_covered_by(affected_files,
-                                                   reviewers_plus_owner)
+        reviewers_plus_owner)
   else:
-    message = ''
     missing_files = owners_db.files_not_covered_by(affected_files, reviewers)
 
   if missing_files:
     output_list = [
         output('Missing %s for these files:\n    %s%s' %
                (needed, '\n    '.join(missing_files), message))]
     if not input_api.is_committing:
       suggested_owners = owners_db.reviewers_for(affected_files, owner_email)
       output_list.append(output('Suggested OWNERS:\n    %s' %
                                 ('\n    '.join(suggested_owners or []))))
@@ skipping 194 matching lines @@
     snapshot("checking description")
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
         input_api, output_api))
     snapshot("checking do not submit in files")
     results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
         input_api, output_api))
   snapshot("done")
   return results