Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237653005: Rename WeakInterfacePtrSet to InterfacePtrSet. (Closed)

Created:
5 years, 5 months ago by rudominer
Modified:
5 years, 5 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Responding to code review. #

Patch Set 3 : Responding to code review take 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -206 lines) Patch
M mojo/common/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A + mojo/common/interface_ptr_set.h View 2 chunks +7 lines, -10 lines 0 comments Download
A + mojo/common/interface_ptr_set_unittest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
D mojo/common/weak_interface_ptr_set.h View 1 chunk +0 lines, -75 lines 0 comments Download
D mojo/common/weak_interface_ptr_set_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M services/tracing/tracing_app.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rudominer
ptal
5 years, 5 months ago (2015-07-17 01:37:32 UTC) #2
viettrungluu
https://codereview.chromium.org/1237653005/diff/1/mojo/common/interface_ptr_set_unittest.cc File mojo/common/interface_ptr_set_unittest.cc (right): https://codereview.chromium.org/1237653005/diff/1/mojo/common/interface_ptr_set_unittest.cc#newcode36 mojo/common/interface_ptr_set_unittest.cc:36: TEST(InterfacePtrSet, FullLifeCycleTest) { nit (which I should have caught ...
5 years, 5 months ago (2015-07-20 16:48:55 UTC) #3
rudominer
done https://codereview.chromium.org/1237653005/diff/1/mojo/common/interface_ptr_set_unittest.cc File mojo/common/interface_ptr_set_unittest.cc (right): https://codereview.chromium.org/1237653005/diff/1/mojo/common/interface_ptr_set_unittest.cc#newcode36 mojo/common/interface_ptr_set_unittest.cc:36: TEST(InterfacePtrSet, FullLifeCycleTest) { On 2015/07/20 16:48:55, viettrungluu wrote: ...
5 years, 5 months ago (2015-07-20 16:56:37 UTC) #4
viettrungluu
Oops, meant to say lgtm w/nit previously.
5 years, 5 months ago (2015-07-20 17:01:04 UTC) #5
rudominer
5 years, 5 months ago (2015-07-20 17:14:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b543d0ff1df3c337f09538b4a04adcf801a65d7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698