services/tracing/tracing_app.h - Issue 1237653005: Rename WeakInterfacePtrSet to InterfacePtrSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/tracing/tracing_app.h

Issue 1237653005: Rename WeakInterfacePtrSet to InterfacePtrSet. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Responding to code review take 2. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/tracing/tracing_app.h

diff --git a/services/tracing/tracing_app.h b/services/tracing/tracing_app.h

index 5eb69ea07f3cc2d9c3548a3feae4889647ae6750..fc9a52bbae399492c9760fb42a8eae6dfd8cf5ea 100644

--- a/services/tracing/tracing_app.h

+++ b/services/tracing/tracing_app.h

@@ -8,8 +8,8 @@

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

+#include "mojo/common/interface_ptr_set.h"

#include "mojo/common/weak_binding_set.h"

-#include "mojo/common/weak_interface_ptr_set.h"

#include "mojo/public/cpp/application/application_delegate.h"

#include "mojo/public/cpp/application/application_impl.h"

#include "mojo/public/cpp/bindings/strong_binding.h"

@@ -44,7 +44,7 @@ class TracingApp : public mojo::ApplicationDelegate,

scoped_ptr<TraceDataSink> sink_;

ScopedVector<CollectorImpl> collector_impls_;

- mojo::WeakInterfacePtrSet<TraceController> controller_ptrs_;

+ mojo::InterfacePtrSet<TraceController> controller_ptrs_;

mojo::Binding<TraceCoordinator> coordinator_binding_;

bool tracing_active_;

mojo::String tracing_categories_;

« no previous file with comments | « mojo/common/weak_interface_ptr_set_unittest.cc ('k') | no next file » | no next file with comments »