Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1237623003: Remove unused bailout reasons. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-frame-constants-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused bailout reasons. This also adds a script to the tools directory that allows to grep for unused bailout reasons. For now the script needs to be run manually. R=mvstanton@chromium.org Committed: https://crrev.com/4b22d5eca21444b0f8567b117895b894448e1460 Cr-Commit-Position: refs/heads/master@{#29609}

Patch Set 1 #

Patch Set 2 : Respect cctest as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -30 lines) Patch
M src/bailout-reason.h View 1 13 chunks +0 lines, -30 lines 0 comments Download
A tools/check-unused-bailouts.sh View 1 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-13 12:06:27 UTC) #1
mvstanton
Cool! LGTM.
5 years, 5 months ago (2015-07-13 12:10:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237623003/20001
5 years, 5 months ago (2015-07-13 12:46:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 13:34:06 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 13:34:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b22d5eca21444b0f8567b117895b894448e1460
Cr-Commit-Position: refs/heads/master@{#29609}

Powered by Google App Engine
This is Rietveld 408576698