Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1235893002: Our JavaScriptFrame::function_slot_object is arch independent. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Our JavaScriptFrame::function_slot_object is arch independent. R=bmeurer@chromium.org Committed: https://crrev.com/79a3cb2eaca846b95aa28c3ed6d854fa8575b9e6 Cr-Commit-Position: refs/heads/master@{#29607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -48 lines) Patch
M src/arm/frames-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/frames-arm64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/frames-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/frames-mips.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips64/frames-mips64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ppc/frames-ppc.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x87/frames-x87.h View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-13 11:31:56 UTC) #1
Benedikt Meurer
LGTM!
5 years, 5 months ago (2015-07-13 12:42:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235893002/1
5 years, 5 months ago (2015-07-13 12:43:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 12:45:23 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 12:45:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79a3cb2eaca846b95aa28c3ed6d854fa8575b9e6
Cr-Commit-Position: refs/heads/master@{#29607}

Powered by Google App Engine
This is Rietveld 408576698