Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1237603003: Add convenience method for converting v8::PersistentBase to v8::Local (Closed)

Created:
5 years, 5 months ago by yurys
Modified:
5 years, 5 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add convenience method for converting v8::PersistentBase to v8::Local The CL addes convenienve method that allows to write code like the following v8::Local<v8::Object> local = v8::Local<v8::Object>::New(global, isolate); in a more readable way: v8::Local<v8::Object> local = global.Get(isolate); There is already v8::Eternal::Get that does similar thing. BUG=None LOG=Y Committed: https://crrev.com/e5a77abcf8c651a1abd3949540ce6c9100ced4ef Cr-Commit-Position: refs/heads/master@{#29616}

Patch Set 1 #

Patch Set 2 : Fixed test compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M include/v8.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
yurys
5 years, 5 months ago (2015-07-13 13:23:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237603003/1
5 years, 5 months ago (2015-07-13 13:24:45 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-13 13:24:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237603003/1
5 years, 5 months ago (2015-07-13 13:25:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2261)
5 years, 5 months ago (2015-07-13 13:30:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237603003/20001
5 years, 5 months ago (2015-07-13 14:14:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 15:02:25 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:02:39 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5a77abcf8c651a1abd3949540ce6c9100ced4ef
Cr-Commit-Position: refs/heads/master@{#29616}

Powered by Google App Engine
This is Rietveld 408576698