Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: test/cctest/test-global-handles.cc

Issue 1237603003: Add convenience method for converting v8::PersistentBase to v8::Local (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed test compilation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 { 373 {
374 HandleScope scope(isolate); 374 HandleScope scope(isolate);
375 v8::Local<v8::Object> object = v8::Object::New(v8_isolate); 375 v8::Local<v8::Object> object = v8::Object::New(v8_isolate);
376 v8::Eternal<v8::Object> eternal(v8_isolate, object); 376 v8::Eternal<v8::Object> eternal(v8_isolate, object);
377 CHECK(!eternal.IsEmpty()); 377 CHECK(!eternal.IsEmpty());
378 CHECK(object == eternal.Get(v8_isolate)); 378 CHECK(object == eternal.Get(v8_isolate));
379 } 379 }
380 380
381 CHECK_EQ(2*kArrayLength + 1, eternal_handles->NumberOfHandles()); 381 CHECK_EQ(2*kArrayLength + 1, eternal_handles->NumberOfHandles());
382 } 382 }
383
384
385 TEST(PersistentBaseGetLocal) {
386 CcTest::InitializeVM();
387 v8::Isolate* isolate = CcTest::isolate();
388
389 v8::HandleScope scope(isolate);
390 v8::Local<v8::Object> o = v8::Object::New(isolate);
391 CHECK(!o.IsEmpty());
392 v8::Persistent<v8::Object> p(isolate, o);
393 CHECK(o == p.Get(isolate));
394 CHECK(v8::Local<v8::Object>::New(isolate, p) == p.Get(isolate));
395
396 v8::Global<v8::Object> g(isolate, o);
397 CHECK(o == g.Get(isolate));
398 CHECK(v8::Local<v8::Object>::New(isolate, g) == g.Get(isolate));
399 }
OLDNEW
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698