tools/metrics/histograms/histograms.xml - Issue 1237403003: [Password manager IOS upsteaming] Upstreaming login database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1237403003: [Password manager IOS upsteaming] Upstreaming login database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Histograms Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/password_manager/core/browser/login_database_ios_unittest.cc ('K') | « components/password_manager/core/browser/login_database_ios_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 08270ea5fea93f5e97200a28a74940ad5107622a..75b4bb91c6c9c670c088b36b14dffcdb7d493c14 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -15548,6 +15548,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="LoginDatabase.DecryptFailure">

vabr (Chromium) 2015/07/22 12:44:32 Please rename the histograms to fit in the Passwor

vabr (Chromium) 2015/07/22 12:44:32 I'm not sure if it is a problem that the histogram

+ <owner>melandory@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <summary>

+ iOS histogram which count failed to retrieve the password from the keychain

vabr (Chromium) 2015/07/22 12:44:32 Suggested rephrasing: Apple's Security Error Code

+ events.

+ </summary>

+</histogram>

+<histogram name="LoginDatabase.EncryptFailure">

+ <owner>melandory@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <summary>

+ iOS histogram which counts failed to save the password to the keychain

vabr (Chromium) 2015/07/22 12:44:32 Suggested rephrasing: Apple's Security Error Code

+ events.

+ </summary>

+</histogram>

<histogram name="ManagedUsers.ChromeOS.PasswordChange"

enum="ManagedUserPasswordChange">

<owner>antrim@chromium.org</owner>