Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1237403003: [Password manager IOS upsteaming] Upstreaming login database (Closed)

Created:
5 years, 5 months ago by melandory
Modified:
5 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager IOS upsteaming] Upstreaming login database BUG=520437 Committed: https://crrev.com/f1db7f7c45a0e23cafc23f41d50ce607ce87c753 Cr-Commit-Position: refs/heads/master@{#358311}

Patch Set 1 : #

Patch Set 2 : Histograms #

Total comments: 17

Patch Set 3 : removed uma && rebased #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -2 lines) Patch
M components/components_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager.gypi View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/login_database.h View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database.cc View 1 2 3 5 chunks +42 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/login_database_ios.cc View 1 2 1 chunk +134 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/login_database_ios_unittest.cc View 1 2 3 4 1 chunk +187 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
melandory
Hi Vaclav, review this CL, please. This CL includes diff between upstream and downstream in ...
5 years, 5 months ago (2015-07-22 08:10:37 UTC) #5
vabr (Chromium)
On 2015/07/22 08:10:37, melandory wrote: > Hi Vaclav, > > review this CL, please. > ...
5 years, 5 months ago (2015-07-22 09:43:06 UTC) #6
vabr (Chromium)
Hi Tanja, I started putting in comments, but I think we should do a bigger ...
5 years, 5 months ago (2015-07-22 12:44:32 UTC) #7
vabr (Chromium)
Hi Tanja, Just confirming what we spoke about: it would be good, if you can ...
5 years, 1 month ago (2015-11-04 11:37:44 UTC) #8
vabr (Chromium)
For the record, the decision to first move this to remove the downstream diff, and ...
5 years, 1 month ago (2015-11-04 11:39:27 UTC) #9
melandory
On 2015/11/04 11:39:27, vabr (Chromium) wrote: > For the record, the decision to first move ...
5 years, 1 month ago (2015-11-06 09:58:52 UTC) #11
vabr (Chromium)
Thanks, Tanja, this LGTM! (For curious drive-by reviewers: these files are picked from iOS downstream. ...
5 years, 1 month ago (2015-11-06 10:05:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237403003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1237403003/140001
5 years, 1 month ago (2015-11-06 12:41:54 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:140001)
5 years, 1 month ago (2015-11-06 12:46:09 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 12:46:48 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f1db7f7c45a0e23cafc23f41d50ce607ce87c753
Cr-Commit-Position: refs/heads/master@{#358311}

Powered by Google App Engine
This is Rietveld 408576698