components/password_manager.gypi - Issue 1237403003: [Password manager IOS upsteaming] Upstreaming login database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager.gypi

Issue 1237403003: [Password manager IOS upsteaming] Upstreaming login database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Histograms Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/components_tests.gyp ('k') | components/password_manager/core/browser/login_database.h » ('j') | components/password_manager/core/browser/login_database_ios_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager.gypi

diff --git a/components/password_manager.gypi b/components/password_manager.gypi

index 83e3a66d49817aec2fad4d6f25e04664494ddaf1..1230094fb518c8c810a28d70ef142647b4840976 100644

--- a/components/password_manager.gypi

+++ b/components/password_manager.gypi

@@ -65,6 +65,7 @@

'password_manager/core/browser/log_router.h',

'password_manager/core/browser/login_database.cc',

'password_manager/core/browser/login_database.h',

+ 'password_manager/core/browser/login_database_ios.cc',

vabr (Chromium) 2015/07/22 12:44:31 Does this compile outside iOS? If not, we should m

'password_manager/core/browser/login_database_mac.cc',

'password_manager/core/browser/login_database_posix.cc',

'password_manager/core/browser/login_database_win.cc',

@@ -111,10 +112,13 @@

'password_manager/core/browser/webdata/password_web_data_service_win.h',

'conditions': [

+ ['OS=="ios"', {

+ 'sources!': [

+ 'password_manager/core/browser/login_database_posix.cc',

+ ],

+ }],

['OS=="mac"', {

'sources!': [

- # TODO(blundell): Provide the iOS login DB implementation and then

- # also exclude the POSIX one from iOS. http://crbug.com/341429

'password_manager/core/browser/login_database_posix.cc',

}],