Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6506)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
index 4c0920d235cedc0c7b9665202be3ad1614aaa0b5..21359920896a2ddbeb381decdd867286e1036cc2 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
@@ -259,6 +259,16 @@ GURL SyncPromoUI::GetSyncPromoURL(const GURL& next_page,
}
// static
+bool SyncPromoUI::IsWebBasedSigninFlowURL(const GURL& url) {
+ if (url.SchemeIs(chrome::kChromeSigninScheme))
+ return true;
+
+ return StartsWithASCII(url.spec(),
+ GaiaUrls::GetInstance()->service_login_url(),
+ false);
Roger Tawa OOO till Jul 10th 2013/02/28 21:13:06 Nit: I think it might be better to compare using G
tim (not reviewing) 2013/03/01 01:53:57 Yeah I didn't intend on committing as is, but I ch
+}
+
+// static
GURL SyncPromoUI::GetNextPageURLForSyncPromoURL(const GURL& url) {
const char* key_name = UseWebBasedSigninFlow() ? kSyncPromoQueryKeyContinue :
kSyncPromoQueryKeyNextPage;

Powered by Google App Engine
This is Rietveld 408576698