signin: force web signin flow initiated visits to accounts.google.com to their own process.

chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 241 matching lines @@
       base::StringAppendF(&url_string, "&%s=%s", kSyncPromoQueryKeyNextPage,
                           net::EscapeQueryParamValue(next_page.spec(),
                                                      false).c_str());
     }
   }
 
   return GURL(url_string);
 }
 
 // static
+bool SyncPromoUI::IsWebBasedSigninFlowURL(const GURL& url) {
+  if (url.SchemeIs(chrome::kChromeSigninScheme))
+    return true;
+
+  return StartsWithASCII(url.spec(),
+                         GaiaUrls::GetInstance()->service_login_url(),
+                         false);

[Roger Tawa OOO till Jul 10th, 2013/02/28 21:13:06]

Nit: I think it might be better to compare using GURL::ReplaceComponents() to
strip off the query part, but up to you if you want to change.

[tim (not reviewing), 2013/03/01 01:53:57]

Yeah I didn't intend on committing as is, but I changed to use GetOrigin and
path() equality.

+}
+
+// static
 GURL SyncPromoUI::GetNextPageURLForSyncPromoURL(const GURL& url) {
   const char* key_name = UseWebBasedSigninFlow() ? kSyncPromoQueryKeyContinue :
       kSyncPromoQueryKeyNextPage;
   std::string value;
   if (net::GetValueForKeyInQuery(url, key_name, &value)) {
     return GURL(value);
   }
   return GURL();
 }
 
@@ skipping 29 matching lines @@
       g_force_web_based_signin_flow;
 #else
   return false;
 #endif
 }
 
 // static
 void SyncPromoUI::ForceWebBasedSigninFlowForTesting(bool force) {
   g_force_web_based_signin_flow = force;
 }