Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9180)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add browser test Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 0a28d0f0c00f5433041fbf7d1d05e903ae5ff555..432d2c13c2fd39f3ad79fe7e9cf0077e4090d3b7 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -844,6 +844,12 @@ bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,
if (http_method != "GET")
return false;
+ // If this is the Signin process, fork all navigations originating from the
+ // renderer. The destination page will then be bucketed back to this Signin
+ // process if it is a Signin url, or to another process if not.
Charlie Reis 2013/03/04 19:22:24 Yeah, I suppose there's no easy way to check wheth
tim (not reviewing) 2013/03/04 23:40:19 I added a CHECK to my if-block to ensure we never
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSigninProcess))
+ return true;
+
// If |url| matches one of the prerendered URLs, stop this navigation and try
// to swap in the prerendered page on the browser process. If the prerendered
// page no longer exists by the time the OpenURL IPC is handled, a normal

Powered by Google App Engine
This is Rietveld 408576698