signin: force web signin flow initiated visits to accounts.google.com to their own process.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 826 matching lines @@
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kInstantProcess))
     return true;
 
   // For now, we skip the rest for POST submissions.  This is because
   // http://crbug.com/101395 is more likely to cause compatibility issues
   // with hosted apps and extensions than WebUI pages.  We will remove this
   // check when cross-process POST submissions are supported.
   if (http_method != "GET")
     return false;
 
+  // If this is the Signin process, fork all navigations originating from the
+  // renderer.  The destination page will then be bucketed back to this Signin
+  // process if it is a Signin url, or to another process if not.

[Charlie Reis, 2013/03/04 19:22:24]

Yeah, I suppose there's no easy way to check whether you're doing a POST to a
valid sign-in URL or not from the renderer process.

Ok, we'll rely on the sign-in page not doing POSTs to untrusted pages until
101395 is fixed.  Can you add something to the comment saying why this check has
to be after the POST check?

[tim (not reviewing), 2013/03/04 23:40:19]

I added a CHECK to my if-block to ensure we never fork on POST without doing
something more careful here.

+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSigninProcess))
+    return true;
+
   // If |url| matches one of the prerendered URLs, stop this navigation and try
   // to swap in the prerendered page on the browser process. If the prerendered
   // page no longer exists by the time the OpenURL IPC is handled, a normal
   // navigation is attempted.
   if (prerender_dispatcher_.get() && prerender_dispatcher_->IsPrerenderURL(url))
     return true;
 
   const ExtensionSet* extensions = extension_dispatcher_->extensions();
 
   // Determine if the new URL is an extension (excluding bookmark apps).
@@ skipping 222 matching lines @@
 }
 
 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories(
     webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
 #if defined(ENABLE_PLUGINS)
   factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
 #endif
 }
 
 }  // namespace chrome