chrome/common/url_constants.cc - Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/url_constants.cc

Issue 12374007: signin: force web signin flow initiated visits to accounts.google.com to their own process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add browser test Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/sync/one_click_signin_helper.cc ('K') | « chrome/common/url_constants.h ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/url_constants.cc

diff --git a/chrome/common/url_constants.cc b/chrome/common/url_constants.cc

index 2341c08b9b8b6b660fb9c4f8f521026fb98b3ad3..385910de7ffe643158a899dc3e21ce43107784eb 100644

--- a/chrome/common/url_constants.cc

+++ b/chrome/common/url_constants.cc

@@ -519,6 +519,13 @@ const char kExtensionResourceScheme[] = "chrome-extension-resource";

const char kChromeSearchScheme[] = "chrome-search";

+// This is used to distinguish URLs belonging to the special web signin flow

+// running in the special signin process from other URLs on the same domain.

+// We do not grant WebUI privilieges / bindings to this process or to URLs of

+// this scheme; enforcement of privileges is handled separately by

+// OneClickSigninHelper.

Charlie Reis 2013/03/04 19:22:24 Great comment. Can you move it to the .h file?

tim (not reviewing) 2013/03/04 23:40:19 Done.

+const char kChromeSigninScheme[] = "chrome-signin";

// Google SafeSearch query parameters.

const char kSafeSearchSafeParameter[] = "safe=active";

const char kSafeSearchSsuiParameter[] = "ssui=on";