Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1237363002: Adds support for Macedonian keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chromeos/ime/input_methods.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9daef964fbafc3ad717b26212140a15dbc37e3fd..392d8cdb33f2a12f380d8553f77c6d5eb109f2fc 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -59082,7 +59082,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="110800" label="xkb:latam::spa">Latin American keyboard</int>
<int value="110801" label="xkb:lt::lit">Lithuanian keyboard</int>
<int value="110802" label="xkb:lv:apostrophe:lav">Latvian keyboard</int>
- <int value="110900" label="xkb:mn::mon">Mongolian keyboard</int>
+ <int value="110900" label="xkb:mk::mkd">Macedonian keyboard</int>
+ <int value="110901" label="xkb:mn::mon">Mongolian keyboard</int>
Ilya Sherman 2015/07/16 04:49:47 Hmm, why did this value change?
Shu Chen 2015/07/16 05:13:35 The ID sequence matters, because the input method
Ilya Sherman 2015/07/16 06:25:31 You should find a mapping that is more stable than
Shu Chen 2015/07/16 06:38:44 Do you have any idea of making the mapping stable?
Ilya Sherman 2015/07/16 06:47:46 The easiest thing to do would be to just compute a
+ <int value="110902" label="xkb:mt::mlt">Maltese keyboard</int>
<int value="111000" label="xkb:no::nob">Norwegian keyboard</int>
<int value="111200" label="xkb:pl::pol">Polish keyboard</int>
<int value="111201" label="xkb:pt::por">Portuguese keyboard</int>
@@ -59105,9 +59107,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="111705" label="xkb:us:altgr-intl:eng">US Extended keyboard</int>
<int value="111706" label="xkb:us:colemak:eng">US Colemak keyboard</int>
<int value="111707" label="xkb:us:dvorak:eng">US Dvorak keyboard</int>
- <int value="111708" label="xkb:us:intl:eng">US International keyboard</int>
- <int value="111709" label="xkb:us:intl:nld">US International keyboard</int>
- <int value="111710" label="xkb:us:intl:por">US International keyboard</int>
+ <int value="111708" label="xkb:us:dvp:eng">US Dvorak Programmer keyboard</int>
+ <int value="111709" label="xkb:us:intl:eng">US International keyboard</int>
+ <int value="111710" label="xkb:us:intl:nld">US International keyboard</int>
+ <int value="111711" label="xkb:us:intl:por">US International keyboard</int>
Ilya Sherman 2015/07/16 04:49:47 Likewise, why did these values change?
Shu Chen 2015/07/16 05:13:35 Ditto. US Dvorak Programmer keyboard was added in
<int value="209700" label="zh-hant-t-i0-array-1992">Array input method</int>
<int value="209900" label="zh-hant-t-i0-cangjie-1987">
Cangjie input method
« no previous file with comments | « chromeos/ime/input_methods.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698