Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1113683003: (Reland) Add programmer dvorak keyboard layout (Closed)

Created:
5 years, 7 months ago by Chirantan Ekbote
Modified:
5 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) Add programmer dvorak keyboard layout BUG=483283 Committed: https://crrev.com/760ee32a919e6ada6a35f0d10855239798d96a2a Cr-Commit-Position: refs/heads/master@{#329593}

Patch Set 1 : Original CL #

Patch Set 2 : Update tests #

Patch Set 3 : Add dvp to open-source xkb manifest #

Patch Set 4 : Update other broken tests #

Messages

Total messages: 20 (3 generated)
Chirantan Ekbote
PTAL. This CL was reverted because it was causing LoginUIKeyboardTest to fail (dvp was in ...
5 years, 7 months ago (2015-04-29 00:56:26 UTC) #2
Chirantan Ekbote
Hi Alexander, ptal.
5 years, 7 months ago (2015-04-29 00:57:40 UTC) #4
Shu Chen
Tests are still failing?
5 years, 7 months ago (2015-04-29 01:04:26 UTC) #5
Chirantan Ekbote
I think I figured it out: I had to add the layout to the xkb_manifest.json ...
5 years, 7 months ago (2015-04-29 01:35:04 UTC) #6
Chirantan Ekbote
Ok, I think I've fixed all the broken tests and the trybots are now green. ...
5 years, 7 months ago (2015-04-29 20:22:38 UTC) #7
Alexander Alekseev
Could you please create an issue for this, explaining why we need this layout?
5 years, 7 months ago (2015-04-29 21:08:26 UTC) #8
Chirantan Ekbote
On 2015/04/29 21:08:26, Alexander Alekseev wrote: > Could you please create an issue for this, ...
5 years, 7 months ago (2015-04-29 21:29:53 UTC) #9
Alexander Alekseev
On 2015/04/29 21:29:53, Chirantan Ekbote wrote: > On 2015/04/29 21:08:26, Alexander Alekseev wrote: > > ...
5 years, 7 months ago (2015-04-30 10:57:21 UTC) #10
Alexander Alekseev
Actually I am not against this modification (from chromeos/login/ point of view). But commits to ...
5 years, 7 months ago (2015-04-30 19:55:59 UTC) #11
Chirantan Ekbote
On 2015/04/30 19:55:59, Alexander Alekseev wrote: > Actually I am not against this modification (from ...
5 years, 7 months ago (2015-04-30 23:01:25 UTC) #12
Chirantan Ekbote
ping. do you have any more concerns or can we land this now?
5 years, 7 months ago (2015-05-05 19:27:17 UTC) #13
Chirantan Ekbote
On 2015/05/05 19:27:17, Chirantan Ekbote wrote: > ping. do you have any more concerns or ...
5 years, 7 months ago (2015-05-06 23:45:09 UTC) #14
Alexander Alekseev
lgtm for chrome/browser/chromeos/login/
5 years, 7 months ago (2015-05-12 14:47:27 UTC) #15
Shu Chen
lgtm
5 years, 7 months ago (2015-05-13 03:45:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113683003/60001
5 years, 7 months ago (2015-05-13 05:30:33 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-13 06:01:00 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 06:01:44 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/760ee32a919e6ada6a35f0d10855239798d96a2a
Cr-Commit-Position: refs/heads/master@{#329593}

Powered by Google App Engine
This is Rietveld 408576698