Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237303003: Move more tests from ChromeShellTest to ChromePublicTest (Closed)

Created:
5 years, 5 months ago by pkotwicz
Modified:
5 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org, gone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more tests from ChromeShellTest to ChromePublicTest BUG=505040 TEST=None Committed: https://crrev.com/ffde5d91dd035af23248634599e17a409b34b8f3 Cr-Commit-Position: refs/heads/master@{#339897}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -1678 lines) Patch
M chrome/android/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppData.java View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java View 2 chunks +3 lines, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java View 1 6 chunks +35 lines, -27 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 4 chunks +11 lines, -12 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 14 chunks +40 lines, -48 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 4 chunks +12 lines, -6 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java View 5 chunks +10 lines, -20 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/SuggestionAnswerTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java View 2 chunks +9 lines, -10 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/NavigationPopupTest.java View 1 chunk +0 lines, -279 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 1 chunk +0 lines, -434 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java View 1 chunk +0 lines, -421 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/omnibox/SuggestionAnswerTest.java View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java View 1 chunk +0 lines, -58 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pkotwicz
tedchoc@ PTAL
5 years, 5 months ago (2015-07-21 20:48:55 UTC) #4
Ted C
lgtm https://codereview.chromium.org/1237303003/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java (right): https://codereview.chromium.org/1237303003/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java#newcode129 chrome/android/javatests/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java:129: TestHttpServerClient.getUrl(NAVIGATION_FROM_XHR_CALLBACK_AND_SHORT_TIMEOUT_PAGE)); can be one line now
5 years, 5 months ago (2015-07-21 21:29:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237303003/60001
5 years, 5 months ago (2015-07-21 23:59:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/94143)
5 years, 5 months ago (2015-07-22 00:21:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237303003/100001
5 years, 5 months ago (2015-07-22 16:54:55 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 5 months ago (2015-07-22 17:23:17 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:24:02 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ffde5d91dd035af23248634599e17a409b34b8f3
Cr-Commit-Position: refs/heads/master@{#339897}

Powered by Google App Engine
This is Rietveld 408576698