Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1237233006: Flip the shut down order in tests. (Closed)

Created:
5 years, 5 months ago by Lei Zhang
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flip the shut down order in tests. This matches the Chromium PDF plugin changes in https://codereview.chromium.org/1230313006/ R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/281d1d293dab54cadd214e5a1c098583fbbe0788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
Did you want a comment here, or a comment on the same spot in the ...
5 years, 5 months ago (2015-07-15 23:41:02 UTC) #2
Tom Sepez
On 2015/07/15 23:41:02, Lei Zhang wrote: > Did you want a comment here, or a ...
5 years, 5 months ago (2015-07-16 00:02:03 UTC) #3
Tom Sepez
lgtm
5 years, 5 months ago (2015-07-16 00:02:17 UTC) #4
Lei Zhang
5 years, 5 months ago (2015-07-16 00:10:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
281d1d293dab54cadd214e5a1c098583fbbe0788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698