Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1230313006: PDF: Revert to the original shut down order for non-XFA. (Closed)

Created:
5 years, 5 months ago by Lei Zhang
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Revert to the original shut down order for non-XFA. Call FPDFDOC_ExitFormFillEnvironment() before FPDF_CloseDocument(), like we did before r303923. BUG=502794 Committed: https://crrev.com/44e52fa05bba53a5865a6dfd666682bc41264fc8 Cr-Commit-Position: refs/heads/master@{#338987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Lei Zhang
5 years, 5 months ago (2015-07-15 23:31:41 UTC) #2
Tom Sepez
Swell. LGTM.
5 years, 5 months ago (2015-07-15 23:32:33 UTC) #3
Tom Sepez
On 2015/07/15 23:32:33, Tom Sepez wrote: > Swell. LGTM. Though there's probably a follow-up CL ...
5 years, 5 months ago (2015-07-15 23:34:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230313006/1
5 years, 5 months ago (2015-07-15 23:35:33 UTC) #6
Lei Zhang
On 2015/07/15 23:34:34, Tom Sepez wrote: > On 2015/07/15 23:32:33, Tom Sepez wrote: > > ...
5 years, 5 months ago (2015-07-15 23:36:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/80884) (exceeded global retry quota)
5 years, 5 months ago (2015-07-16 01:36:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230313006/1
5 years, 5 months ago (2015-07-16 04:19:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 04:23:12 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 04:24:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44e52fa05bba53a5865a6dfd666682bc41264fc8
Cr-Commit-Position: refs/heads/master@{#338987}

Powered by Google App Engine
This is Rietveld 408576698