Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1237213004: Fixed valgrind issues with libjpeg-turbo (Closed)

Created:
5 years, 5 months ago by msarett
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixed valgrind issues with libjpeg-turbo The fixes are in the updated libjpeg-turbo repository pulled in by DEPS. The fixes are detailed in the linked skia bug. To summarize briefly, we now use calloc() instead of malloc(). BUG=skia:4030 Committed: https://skia.googlesource.com/skia/+/02b5aa3cacf9a288043029300b988d7b4b26ba5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind.supp View 1 chunk +0 lines, -62 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
msarett
5 years, 5 months ago (2015-07-14 20:48:00 UTC) #2
mtklein
lgtm
5 years, 5 months ago (2015-07-14 21:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237213004/1
5 years, 5 months ago (2015-07-14 21:18:04 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 21:40:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/02b5aa3cacf9a288043029300b988d7b4b26ba5a

Powered by Google App Engine
This is Rietveld 408576698