runtime/observatory/tests/service/test_helper.dart - Issue 1237203002: Insert debug step check at the beginning of a function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1237203002: Insert debug step check at the beginning of a function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/test_helper.dart

diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart

index f47f1cd45e9bfbf3778be5e9a793482a222146cf..7cf48caa8684eb44ec4f4fc5d0796f9020e6600d 100644

--- a/runtime/observatory/tests/service/test_helper.dart

+++ b/runtime/observatory/tests/service/test_helper.dart

@@ -155,7 +155,9 @@ Future processServiceEvents(VM vm,

}

-Future<Isolate> hasStoppedAtBreakpoint(Isolate isolate) {

+Future<Isolate> hasStoppedAtBreakpoint(Isolate isolate) async {

+ await isolate.reload(); // Might have missed pauseEvent.

if ((isolate.pauseEvent != null) &&

(isolate.pauseEvent.kind == ServiceEvent.kPauseBreakpoint)) {

// Already waiting at a breakpoint.