Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1237203002: Insert debug step check at the beginning of a function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl_test.cc ('k') | tests/standalone/debugger/break_at_equals_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index abdd58e44ff523cd98b833ddbb8e43e63d437dec..9457956bf2f65d371e659271540ca62f499993b4 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -4198,6 +4198,11 @@ void EffectGraphVisitor::VisitSequenceNode(SequenceNode* node) {
ASSERT((node->label() == NULL) || !is_top_level_sequence);
NestedBlock nested_block(owner(), node);
+ if (FLAG_support_debugger && is_top_level_sequence) {
+ AddInstruction(new(Z) DebugStepCheckInstr(function.token_pos(),
Cutch 2015/07/14 19:54:36 I wonder if you could insert this after the Graphc
rmacnak 2015/07/14 22:28:29 We don't seem to have the right things in scope to
+ RawPcDescriptors::kRuntimeCall));
+ }
+
if (num_context_variables > 0) {
// The local scope declares variables that are captured.
// Allocate and chain a new context (Except don't chain when at the function
« no previous file with comments | « runtime/vm/debugger_api_impl_test.cc ('k') | tests/standalone/debugger/break_at_equals_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698