Support for connecting to localhost on the chromoting test driver.

remoting/test/test_chromoting_client_unittest.cc

Index: remoting/test/test_chromoting_client_unittest.cc
diff --git a/remoting/test/test_chromoting_client_unittest.cc b/remoting/test/test_chromoting_client_unittest.cc
index 9f232891905ce0420b1c4a28b8fa71146e2e324c..9a6797405dcd8cf8f590d486afc1c6f2890131dd 100644
--- a/remoting/test/test_chromoting_client_unittest.cc
+++ b/remoting/test/test_chromoting_client_unittest.cc
@@ -6,6 +6,7 @@
 
 #include "base/message_loop/message_loop.h"
 #include "remoting/protocol/fake_connection_to_host.h"
+#include "remoting/test/remote_host_info.h"

[tonychun, 2015/07/20 18:13:01]

Tests use remote_host_info

[joedow, 2015/07/20 18:23:07]

Sorry for the late comment on this file, but I'm wondering why the unittests
don't use a ConnectionSetupInfo struct here instead of a remote host info? 
Let's remove the RHI dependency here and use the struct that you created.

 #include "remoting/test/test_chromoting_client.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -112,8 +113,8 @@ void TestChromotingClientTest::ConnectionReady(bool ready) {
 }
 
 TEST_F(TestChromotingClientTest, StartConnectionAndDisconnect) {
-  test_chromoting_client_->StartConnection(kTestUserName, kAccessToken,
-                                           remote_host_info_);
+  test_chromoting_client_->StartConnection(
+    remote_host_info_.GenerateConnectionSetupInfo(kAccessToken, kTestUserName));
   EXPECT_EQ(protocol::ConnectionToHost::State::CONNECTING, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
@@ -146,8 +147,8 @@ TEST_F(TestChromotingClientTest, StartConnectionAndDisconnect) {
 
 TEST_F(TestChromotingClientTest,
        StartConnectionThenFailWithAuthenticationError) {
-  test_chromoting_client_->StartConnection(kTestUserName, kAccessToken,
-                                           remote_host_info_);
+  test_chromoting_client_->StartConnection(
+    remote_host_info_.GenerateConnectionSetupInfo(kAccessToken, kTestUserName));
   EXPECT_EQ(protocol::ConnectionToHost::State::CONNECTING, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
@@ -167,8 +168,8 @@ TEST_F(TestChromotingClientTest,
 }
 
 TEST_F(TestChromotingClientTest, StartConnectionThenFailWithUnknownError) {
-  test_chromoting_client_->StartConnection(kTestUserName, kAccessToken,
-                                           remote_host_info_);
+  test_chromoting_client_->StartConnection(
+    remote_host_info_.GenerateConnectionSetupInfo(kAccessToken, kTestUserName));
   EXPECT_EQ(protocol::ConnectionToHost::State::CONNECTING, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);