Support for connecting to localhost on the chromoting test driver.

remoting/test/test_chromoting_client_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/message_loop/message_loop.h"
 #include "remoting/protocol/fake_connection_to_host.h"
+#include "remoting/test/remote_host_info.h"

[tonychun, 2015/07/20 18:13:01]

Tests use remote_host_info

[joedow, 2015/07/20 18:23:07]

Sorry for the late comment on this file, but I'm wondering why the unittests
don't use a ConnectionSetupInfo struct here instead of a remote host info? 
Let's remove the RHI dependency here and use the struct that you created.

 #include "remoting/test/test_chromoting_client.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 const char kTestUserName[] = "test_user@faux_address.com";
 const char kAccessToken[] = "faux_access_token";
 }
 
 namespace remoting {
 namespace test {
@@ skipping 86 matching lines @@
   }
 }
 
 void TestChromotingClientTest::ConnectionReady(bool ready) {
   if (ready) {
     is_connected_to_host_ = true;
   }
 }
 
 TEST_F(TestChromotingClientTest, StartConnectionAndDisconnect) {
-  test_chromoting_client_->StartConnection(kTestUserName, kAccessToken,
-                                           remote_host_info_);
+  test_chromoting_client_->StartConnection(
+    remote_host_info_.GenerateConnectionSetupInfo(kAccessToken, kTestUserName));
   EXPECT_EQ(protocol::ConnectionToHost::State::CONNECTING, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 
   // Simulate an AUTHENTICATED message being sent from the Jingle session.
   fake_connection_to_host_->SignalStateChange(protocol::Session::AUTHENTICATED,
                                               protocol::OK);
   EXPECT_EQ(protocol::ConnectionToHost::State::AUTHENTICATED,
             connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
@@ skipping 12 matching lines @@
   EXPECT_TRUE(is_connected_to_host_);
 
   test_chromoting_client_->EndConnection();
   EXPECT_EQ(protocol::ConnectionToHost::State::CLOSED, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 }
 
 TEST_F(TestChromotingClientTest,
        StartConnectionThenFailWithAuthenticationError) {
-  test_chromoting_client_->StartConnection(kTestUserName, kAccessToken,
-                                           remote_host_info_);
+  test_chromoting_client_->StartConnection(
+    remote_host_info_.GenerateConnectionSetupInfo(kAccessToken, kTestUserName));
   EXPECT_EQ(protocol::ConnectionToHost::State::CONNECTING, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 
   fake_connection_to_host_->SignalStateChange(protocol::Session::FAILED,
                                               protocol::AUTHENTICATION_FAILED);
   EXPECT_EQ(protocol::ConnectionToHost::State::FAILED, connection_state_);
   EXPECT_EQ(protocol::ErrorCode::AUTHENTICATION_FAILED, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 
   // Close the connection via the TestChromotingClient and verify the error
   // state is persisted.
   test_chromoting_client_->EndConnection();
   EXPECT_EQ(protocol::ConnectionToHost::State::FAILED, connection_state_);
   EXPECT_EQ(protocol::ErrorCode::AUTHENTICATION_FAILED, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 }
 
 TEST_F(TestChromotingClientTest, StartConnectionThenFailWithUnknownError) {
-  test_chromoting_client_->StartConnection(kTestUserName, kAccessToken,
-                                           remote_host_info_);
+  test_chromoting_client_->StartConnection(
+    remote_host_info_.GenerateConnectionSetupInfo(kAccessToken, kTestUserName));
   EXPECT_EQ(protocol::ConnectionToHost::State::CONNECTING, connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 
   // Simulate an AUTHENTICATED message being sent from the Jingle session.
   fake_connection_to_host_->SignalStateChange(protocol::Session::AUTHENTICATED,
                                               protocol::OK);
   EXPECT_EQ(protocol::ConnectionToHost::State::AUTHENTICATED,
             connection_state_);
   EXPECT_EQ(protocol::OK, error_code_);
@@ skipping 20 matching lines @@
   // Close the connection via the TestChromotingClient and verify the error
   // state is persisted.
   test_chromoting_client_->EndConnection();
   EXPECT_EQ(protocol::ConnectionToHost::State::FAILED, connection_state_);
   EXPECT_EQ(protocol::ErrorCode::UNKNOWN_ERROR, error_code_);
   EXPECT_FALSE(is_connected_to_host_);
 }
 
 }  // namespace test
 }  // namespace remoting