Source/core/xmlhttprequest/XMLHttpRequest.h - Issue 1237063002: Allocate XMLHttpRequest on the eagerly finalized heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequest.h

Issue 1237063002: Allocate XMLHttpRequest on the eagerly finalized heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add macro for testing eager finalization Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xmlhttprequest/XMLHttpRequest.h

diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.h b/Source/core/xmlhttprequest/XMLHttpRequest.h

index 5dae98a154174bf0a60c95015ccd04b57b1ac9b1..dfe0b31ce9f1fd73e40d9df610763a4b57e70564 100644

--- a/Source/core/xmlhttprequest/XMLHttpRequest.h

+++ b/Source/core/xmlhttprequest/XMLHttpRequest.h

@@ -140,6 +140,12 @@ public:

DEFINE_ATTRIBUTE_EVENT_LISTENER(readystatechange);

+ // (Also) eagerly finalized so as to prevent access to the eagerly finalized

+ // progress event throttle.

+ EAGERLY_FINALIZE();

+#if !ENABLE(OILPAN)

+ DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();

+#endif

DECLARE_VIRTUAL_TRACE();

private:

« no previous file with comments | « no previous file | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »