[rAC] Do not re-create bubble window unnecessarily

[rAC] Do not re-create bubble window unnecessarily

Prevent error bubbles from being recreated every single time a
validation operation on the current field succeeds. Only destroy
bubble if the anchor field changes.

BUG=331147
R=isherman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244228

[Ilya Sherman, 2014-01-07 00:57:15]

Chunk mismatches; mind re-uploading?

[groby-ooo-7-16, 2014-01-07 01:21:55]

Once more unto the breach, dear friends,
or close the wall up with our chunking dead.

PTAL.

[Ilya Sherman, 2014-01-08 00:25:37]

Thanks :)

https://codereview.chromium.org/123703002/diff/120001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/123703002/diff/120001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:103:
errorBubbleAnchorView_ = nil;
Hmm, why does this reset the anchor view?  Might be worth an explanatory comment
inline in the code.

https://codereview.chromium.org/123703002/diff/120001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:174: }
nit: Why curlies?

[Ilya Sherman, 2014-01-08 00:27:41]

Hmm, looking at the bug report, it sounds like the behavior we want is to hide
the bubble and keep it closed, rather than keeping the bubble open.  Am I
misunderstanding something?

[groby-ooo-7-16, 2014-01-08 01:03:52]

I think there's a misunderstanding, yes.  While the bug _claims_ we should close
the bubble, current behavior on Views is to keep the bubble open until the user
is finished typing or the field validates.

The only difference after this change is that Views does not update the message
text while typing, OSX does.

[Ilya Sherman, 2014-01-08 01:39:21]

On 2014/01/08 01:03:52, groby wrote:
> I think there's a misunderstanding, yes.  While the bug _claims_ we should
close
> the bubble, current behavior on Views is to keep the bubble open until the
user
> is finished typing or the field validates.
> 
> The only difference after this change is that Views does not update the
message
> text while typing, OSX does.

Ok, thanks for ze clarification.  In that case, I just have the two comments
that are inline in the code review :)

[groby-ooo-7-16, 2014-01-08 20:15:31]

https://codereview.chromium.org/123703002/diff/120001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/123703002/diff/120001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:103:
errorBubbleAnchorView_ = nil;
On 2014/01/08 00:25:37, Ilya Sherman (Away Jan11-Feb2) wrote:
> Hmm, why does this reset the anchor view?  Might be worth an explanatory
comment
> inline in the code.

You asked for it. It's long :)

https://codereview.chromium.org/123703002/diff/120001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:174: }
On 2014/01/08 00:25:37, Ilya Sherman (Away Jan11-Feb2) wrote:
> nit: Why curlies?

Habit. Done.

[Ilya Sherman, 2014-01-08 21:48:33]

Thanks!  LGTM w/ a nit:

https://codereview.chromium.org/123703002/diff/270001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/autofill_details_container.mm (right):

https://codereview.chromium.org/123703002/diff/270001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/autofill_details_container.mm:107: // the
dialog and error bubble is reshown, leading to a missign error bubble.
nit: "missign" -> "missing"

[commit-bot: I haz the power, 2014-01-10 18:20:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/123703002/340001

[commit-bot: I haz the power, 2014-01-10 20:17:48]

Change committed as 244228