[rAC] Do not re-create bubble window unnecessarily

chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_details_container.h"
 
 #include <algorithm>
 
 #include "base/mac/foundation_util.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_view_delegate.h"
@@ skipping 82 matching lines @@
   }
   return nil;
 }
 
 - (void)modelChanged {
   for (AutofillSectionContainer* details in details_.get())
     [details modelChanged];
 }
 
 - (BOOL)validate {
+  errorBubbleAnchorView_ = nil;

[Ilya Sherman, 2014/01/08 00:25:37]

Hmm, why does this reset the anchor view?  Might be worth an explanatory comment
inline in the code.

[groby-ooo-7-16, 2014/01/08 20:15:31]

You asked for it. It's long :)

+
   bool allValid = true;
   for (AutofillSectionContainer* details in details_.get()) {
     if (![[details view] isHidden])
       allValid = [details validateFor:autofill::VALIDATE_FINAL] && allValid;
   }
   return allValid;
 }
 
 - (NSView*)firstInvalidField {
   return [self firstEditableFieldMatchingBlock:
@@ skipping 36 matching lines @@
 }
 
 - (void)errorBubbleWindowWillClose:(NSNotification*)notification {
   DCHECK_EQ([notification object], [errorBubbleController_ window]);
 
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center removeObserver:self
                     name:NSWindowWillCloseNotification
                   object:[errorBubbleController_ window]];
   errorBubbleController_ = nil;
+  errorBubbleAnchorView_ = nil;
 }
 
 - (void)showErrorBubbleForField:(NSControl<AutofillInputField>*)field {
-  if (errorBubbleController_)
+  // If there is already a bubble controller handling this field, reuse.
+  if (errorBubbleController_ && errorBubbleAnchorView_ == field) {
+    [errorBubbleController_ setMessage:[field validityMessage]];
+
+    return;
+  }
+
+  if (errorBubbleController_) {
     [errorBubbleController_ close];
+  }

[Ilya Sherman, 2014/01/08 00:25:37]

nit: Why curlies?

[groby-ooo-7-16, 2014/01/08 20:15:31]

Habit. Done.

   DCHECK(!errorBubbleController_);
   NSWindow* parentWindow = [field window];
   DCHECK(parentWindow);
   errorBubbleController_ =
         [[AutofillBubbleController alloc]
             initWithParentWindow:parentWindow
                          message:[field validityMessage]];
 
   // Handle bubble self-deleting.
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
@@ skipping 22 matching lines @@
 
   } else {
     anchorPoint = NSMakePoint(NSMinX(viewRect), NSMinY(viewRect));
     [[errorBubbleController_ bubble] setArrowLocation:info_bubble::kTopLeft];
     [[errorBubbleController_ bubble] setAlignment:
         info_bubble::kAlignLeftEdgeToAnchorEdge];
   }
   [errorBubbleController_ setAnchorPoint:
       [parentWindow convertBaseToScreen:anchorPoint]];
 
+  errorBubbleAnchorView_ = field;
   [errorBubbleController_ showWindow:self];
 }
 
 - (void)hideErrorBubble {
   [errorBubble_ setHidden:YES];
 }
 
 - (void)updateMessageForField:(NSControl<AutofillInputField>*)field {
   // Ignore fields that are not first responder. Testing this is a bit
   // convoluted, since for NSTextFields with firstResponder status, the
@@ skipping 47 matching lines @@
     }
 
     selectedField = field;
     selectedFieldOrigin = fieldOrigin;
   }
 
   return selectedField;
 }
 
 @end